Skip to content

YARN-10869. CS considers only the default maximum-allocation-mb/vcore property as a maximum when it creates dynamic queues#3225

Merged
szilard-nemeth merged 1 commit intoapache:trunkfrom
brumi1024:YARN-10869
Jul 29, 2021
Merged

Conversation

@brumi1024
Copy link
Member

@brumi1024 brumi1024 commented Jul 22, 2021

… property as a maximum when it creates dynamic queues

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

@brumi1024
YARN-10869. CS considers only the default maximum-allocation-mb/vcore…
c8a234e 
… property as a maximum when it creates dynamic queues
@hadoop-yetus
Copy link

hadoop-yetus commented Jul 22, 2021

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 37m 40s trunk passed
+1 💚 compile 1m 15s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 1m 6s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 0m 58s trunk passed
+1 💚 mvnsite 1m 6s trunk passed
+1 💚 javadoc 0m 52s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 50s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 2m 24s trunk passed
+1 💚 shadedclient 19m 50s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 3s the patch passed
+1 💚 compile 1m 9s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 1m 9s the patch passed
+1 💚 compile 0m 55s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 0m 55s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 48s /results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 145 unchanged - 0 fixed = 147 total (was 145)
+1 💚 mvnsite 1m 0s the patch passed
+1 💚 javadoc 0m 46s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 38s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 2m 31s the patch passed
+1 💚 shadedclient 19m 56s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 94m 59s hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
189m 49s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3225/1/artifact/out/Dockerfile
GITHUB PR #3225
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 9982126173ff 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c8a234e
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3225/1/testReport/
Max. process+thread count 917 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3225/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@9uapaw
Copy link
Contributor

9uapaw commented Jul 23, 2021

Thank you for the patch @bteke. This is a subtle issue, good finding! One note:
Is there any drawbacks of not using cloned configuration objects? I can see that the initializeLeafQueueConfigs also clones the config object, and so does the getLeafQueueConfigs (which is doubly meaningless, as it is creating a new Configuration object which is passed to a new CSConfiguration object immediately). I would argue that in order to eliminate the root cause of this issue is to remove these clonings, if they are not essential. As of now, I do not see any advantages of this behaviour over simply populating the csContext config with the templates.

@brumi1024
Copy link
Member Author

brumi1024 commented Jul 26, 2021

@9uapaw thanks for checking this. I can think of one thing against populating the csContext config: if someone uses a large number of dynamically created queues (like user based ones with a large pool, or application name based dynamic queues, etc) the original configuration object could become pretty large, so some kind of property removal logic could be introduced.

@szilard-nemeth
Copy link
Contributor

szilard-nemeth commented Jul 29, 2021 •
edited
Loading

Thanks @brumi1024 for working on this. The code change looks good to me, committed to trunk.

@szilard-nemeth szilard-nemeth changed the title YARN-10869. CS considers only the default maximum-allocation-mb/vcore… YARN-10869. CS considers only the default maximum-allocation-mb/vcore property as a maximum when it creates dynamic queues Jul 29, 2021
@szilard-nemeth szilard-nemeth merged commit ac0a4e7 into apache:trunk Jul 29, 2021
@brumi1024 brumi1024 deleted the YARN-10869 branch July 29, 2021 16:25
@brumi1024 brumi1024 restored the YARN-10869 branch August 2, 2021 15:17
brumi1024 added a commit to brumi1024/hadoop that referenced this pull request Sep 30, 2021
@brumi1024
YARN-10869. CS considers only the default maximum-allocation-mb/vcore…
40a07fa 
… property as a maximum when it creates dynamic queues (apache#3225)

Co-authored-by: Benjamin Teke <bteke@cloudera.com>
@brumi1024 brumi1024 mentioned this pull request Sep 30, 2021
Merged
4 tasks
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@brumi1024
YARN-10869. CS considers only the default maximum-allocation-mb/vcore…
fab24cc 
… property as a maximum when it creates dynamic queues (apache#3225)

Co-authored-by: Benjamin Teke <bteke@cloudera.com>
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@brumi1024
COMPX-6769: YARN-10869. CS considers only the default maximum-allocat…
cae3894 
…ion-mb/vcore property as a maximum when it creates dynamic queues (apache#3225)

Co-authored-by: Benjamin Teke <bteke@cloudera.com>
(cherry picked from commit ac0a4e7)
Change-Id: Ia8bfcf0694dc707ba5a5dabf042f30540da14084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brumi1024 @hadoop-yetus @9uapaw @szilard-nemeth